Skip to content

Use typed ranges for Color #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Use typed ranges for Color #41

merged 5 commits into from
Dec 16, 2024

Conversation

yevhenii-nadtochii
Copy link
Contributor

@yevhenii-nadtochii yevhenii-nadtochii commented Dec 16, 2024

This PR applies the latest config and fixes range definitions in color.proto. Now, they are set with RangeOption instead of plain string.

The library version has been bumped to 2.0.0-SNAPSHOT.130.

@yevhenii-nadtochii yevhenii-nadtochii self-assigned this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.18%. Comparing base (dbd8f73) to head (7b19592).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #41   +/-   ##
=========================================
  Coverage     94.18%   94.18%           
  Complexity       76       76           
=========================================
  Files            13       13           
  Lines           275      275           
  Branches         26       26           
=========================================
  Hits            259      259           
  Misses           12       12           
  Partials          4        4           

@yevhenii-nadtochii yevhenii-nadtochii marked this pull request as ready for review December 16, 2024 13:18
@yevhenii-nadtochii
Copy link
Contributor Author

@armiol @alexander-yevsyukov PTAL

@yevhenii-nadtochii yevhenii-nadtochii added this pull request to the merge queue Dec 16, 2024
Merged via the queue into master with commit 9ba1399 Dec 16, 2024
7 checks passed
@yevhenii-nadtochii yevhenii-nadtochii deleted the use-typed-range branch December 16, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants