Plugin API improvements #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Rename `SpineSettingsExtension` to `RootSettingsExtension`. * Pull the `Versions` class to the package level.
Also: * Remove trailing empty line.
armiol
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Project.spineExtension<E>()which allows to obtain an extension nested underProject.rootExtensionby its typeE.The creation of an extension, for both
ProjectandSettings, is now delegated to theExtensionSpecclass. The class now checks if an extension already exists, which helps in solving issues with applying a plugin more than once via its class.Other notable changes
SpineSettingsExtensionwas renamed toRootSettingsExtension.Versionswas pulled to the package level.protocoutput inGenerateProtoTask.setup()was reverted back to the body of the function, instead of being executed by the configured task ondoFirst. This fixed the issue of duplicated Kotlin declarations in the generated code.config.8.14.1.