Add support for customising creation of extensions #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In details: * Add `hashCode()`, `equals()`, and `toString()`. * Rename `ExtensionSpec.createIn()` to `findOrCreateIn()` *
Also: * Rename `extensionParent` property to `dslParent`. *
Also: * Document the `StubPlugin` class.
alexander-yevsyukov
changed the title
armiol
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the API for creating extensions or Gradle DSL. Previously, only the cll to
ExtensionContainer.create(String, Class)method was available. Now it is possible to call other methods ofExtensionContainer.Changes in details
AbstractPluginwas introduced to encapsulate the general way of adding extensions and remembering a target to which the plugin is applied.SettingsPluginnow descends fromAbstractPlugin.ExtensionSpecwas renamed toDslSpecand madeopenfor inheritance. Since it is not longer adata class, it gotequals(),hashCode(), andtoString().DslSpec.createIn()was renamed tofindOrCreateIn()because this is what it does.Plugin.extensionParentproperty was renamed todslParent.SettingsPluginnow uses theDslSpecfor creating the extension it adds.