New settings API #116
Merged
New settings API #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... until Validation codegen fully handles these types.
... to match new conventions.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #116 +/- ##
============================================
+ Coverage 34.34% 36.54% +2.19%
- Complexity 324 342 +18
============================================
Files 123 123
Lines 2428 2430 +2
Branches 195 197 +2
============================================
+ Hits 834 888 +54
+ Misses 1537 1483 -54
- Partials 57 59 +2 |
armiol
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts new conventions for passing settings to plugins recently introduced by ProtoData.
Notable changes
EntityStateandCommandMessageare now handled byMessage.requiresRuntimeValidation()extension function to handle the cases of assumed validation constraint for the first message field. Later this would be handled by codegen.java-tests/consumer/is now copied to theprotodata/settings/directory to follow the new protocol.