Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consumerId property for ValidationPolicy components #118

Merged
merged 7 commits into from
Jan 26, 2024

Conversation

alexander-yevsyukov
Copy link
Collaborator

@alexander-yevsyukov alexander-yevsyukov commented Jan 26, 2024

This PR makes descendants of ValidationPolicy to use the ValidationPlugin class name as their ID. Before this fix policies could not load ValidationConfig instance because they requested it via own class names.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Jan 26, 2024
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review January 26, 2024 13:51
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Merging #118 (65f2792) into master (d020c2e) will increase coverage by 0.10%.
The diff coverage is 50.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #118      +/-   ##
============================================
+ Coverage     36.54%   36.64%   +0.10%     
  Complexity      342      342              
============================================
  Files           123      124       +1     
  Lines          2430     2423       -7     
  Branches        197      197              
============================================
  Hits            888      888              
+ Misses         1483     1476       -7     
  Partials         59       59              

@alexander-yevsyukov alexander-yevsyukov merged commit e5b870b into master Jan 26, 2024
@alexander-yevsyukov alexander-yevsyukov deleted the fix-consumer-id branch January 26, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants