Migrate to new ProtoData #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #120 +/- ##
=========================================
Coverage 36.64% 36.64%
Complexity 342 342
=========================================
Files 124 124
Lines 2423 2423
Branches 197 197
=========================================
Hits 888 888
Misses 1476 1476
Partials 59 59 |
armiol
requested changes
Mar 21, 2024
There was a problem hiding this comment.
@alexander-yevsyukov LGTM in general. Please see my comments.
java-tests/validation-gen/src/test/java/io/spine/test/tools/validate/CustomConstraintsTest.java
Outdated
Show resolved
Hide resolved
java-tests/validation-gen/src/test/java/io/spine/test/tools/validate/IsValid.java
Outdated
Show resolved
Hide resolved
.../validation-gen/src/test/java/io/spine/test/tools/validate/rule/BytesAllRequiredFactory.java
Outdated
Show resolved
Hide resolved
java-tests/validating-options/src/test/proto/bytes_direction_option.proto
Outdated
Show resolved
Hide resolved
armiol
approved these changes
Mar 21, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates to new ProtoData addressing the breaking API changes related to new package and artifact structure.
Other notable changes
Integration tests related to Validation were copied from McJava.
The history of the code changes in these tests was not preserved because of little value comparing to the efforts.
Should we need the history, we could obtain it from
mc-javarepository.Later these tests would be reviewed and updated.
Codegen-related tests that used to be under
java-runtimemoved underjava-tests/runtime.This is done to test the currently developed codegen, rather than one used by McJava applied to
java-runtimemodule.Validation codegen was disabled under
java-runtimemodule to ease the migration during next breaking API change.