Skip to content

Adopt newer ProtoData API #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 28, 2024
Merged

Adopt newer ProtoData API #125

merged 19 commits into from
Jun 28, 2024

Conversation

alexander-yevsyukov
Copy link
Collaborator

@alexander-yevsyukov alexander-yevsyukov commented Jun 27, 2024

This PR adopts new API introduced in ProtoData v0.30.0.

Notable changes

  • The code was updated to take into account the new generic parameter L of the SourceFile class.
  • Custom options in integration tests are now registered using @AutoService (using Kotlin class via KSP).
  • config was updated.
  • Some calls to Java Stream API were ported to Kotlin API.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Jun 27, 2024
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review June 28, 2024 14:47
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 31.81818% with 15 lines in your changes missing coverage. Please review.

Project coverage is 38.32%. Comparing base (7cba2f0) to head (37ad4ce).
Report is 14 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #125      +/-   ##
============================================
+ Coverage     36.64%   38.32%   +1.67%     
- Complexity      342      353      +11     
============================================
  Files           124      125       +1     
  Lines          2423     2338      -85     
  Branches        197      197              
============================================
+ Hits            888      896       +8     
+ Misses         1476     1380      -96     
- Partials         59       62       +3     

@alexander-yevsyukov alexander-yevsyukov merged commit bc1aea1 into master Jun 28, 2024
7 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the adopt-newer-protodata branch June 28, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants