generated from SpineEventEngine/template
-
Notifications
You must be signed in to change notification settings - Fork 0
Implement ValidatingBuilder
instead of McJava
#127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Extract common search for message types.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #127 +/- ##
============================================
- Coverage 38.32% 37.82% -0.51%
Complexity 353 353
============================================
Files 125 127 +2
Lines 2338 2369 +31
Branches 197 200 +3
============================================
Hits 896 896
- Misses 1380 1411 +31
Partials 62 62 |
armiol
approved these changes
Jul 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-yevsyukov LGTM with a minor comment.
java/src/main/kotlin/io/spine/validation/java/JavaRendererExts.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the Validation library make
Builder
classes implementValidatingBuilder
instead of McJava.Currently, McJava does that via the
io.spine.tools.mc.java.protoc.message.BuilderGen
and associated classes which work in theprotoc
plugin of McJava.This PR introduces
ImplementValidatingBuilder
renderer which makesBuilder
classes implementValidatingBuilder
. Adding the code is done only if theBuilder
class does not implement the interface already. Such a case is possible when older McJava is used together with new Validation. Once McJava migrates to newer Validation, the check would be alwaysfalse
.