Bump McJava and Validation #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... because now it makes `Builder` implement `ValidatingBuilder`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #128 +/- ##
=========================================
Coverage 37.82% 37.82%
Complexity 353 353
=========================================
Files 127 127
Lines 2369 2369
Branches 200 200
=========================================
Hits 896 896
Misses 1411 1411
Partials 62 62 |
armiol
approved these changes
Jul 17, 2024
proto/context/build.gradle.kts
Outdated
| } | ||
| } | ||
| } | ||
| //modelCompiler { |
There was a problem hiding this comment.
If the whole thing works together with tests, maybe we could kill these commented portions in this and other files?
alexander-yevsyukov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates to newer McJava, which no longer makes
Message.BuilderimplementValidatingBuilderinterface.Because of this change, codegen for the backend now have to use Validation features, and its version also bumped.