Skip to content

Migrate to new ProtoData #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Sep 25, 2024
Merged

Migrate to new ProtoData #134

merged 21 commits into from
Sep 25, 2024

Conversation

alexander-yevsyukov
Copy link
Collaborator

@alexander-yevsyukov alexander-yevsyukov commented Sep 21, 2024

This PR migrates Validation to new package structure of ProtoData, performing conversion from the legacy types where appropriate.

The PR also sorts out the matter of using build time and compile time dependencies. It is expected that changes introduced under buildSrc would be later propagated to config.

Changes in buildSrc

  • ScriptHandlerScope got two extension values called mcJava and protoData as shortcuts for the corresponding dependency objects. Now it's possible to use these properties instead of local variables that reference the objects. Before this, we had to use the variables because imports are not yet visible under buildScript block.
  • McJava object was pulled to the package level. This way it would be easy to locate this frequently used dependency.
  • ProtoData object got the module property so that it's possible to use custom versions for a classpath dependency under buildSrc.
  • ProtoData.pluginLib() method was made private to avoid its misuse in the build scripts. The method only applies when using locally deployed ProtoData Gradle plugin. We do not publish the artifact with the referenced coordinates when publishing to Gradle Plugin Portal.
  • Several previously deprecated properties of dependency objects were removed.
  • module build script was adjusted to use BuildSettings object from buildSrc.
  • Project.productionModules extension was copied from McJava. We do not have the need for the extension in Validation at the moment. But it will be needed during migration to PSI-based codegen.
  • DependencyResolution extensions for forcing the version of base were copied from McJava.

Changes to the build

  • Dependency on McJava.pluginLib was pushed down to the modules from the root build script. This we we have the control on the versions used by production code and integration test modules.
  • Dependencies on McJava and ProtoData for build and compile time were set and forced for production and integration test modules.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Sep 21, 2024
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review September 23, 2024 17:20
@alexander-yevsyukov alexander-yevsyukov marked this pull request as draft September 23, 2024 17:20
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 37.91%. Comparing base (b9da2b2) to head (98463d0).
Report is 22 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #134      +/-   ##
============================================
- Coverage     38.07%   37.91%   -0.17%     
  Complexity      353      353              
============================================
  Files           126      125       -1     
  Lines          2353     2363      +10     
  Branches        193      195       +2     
============================================
  Hits            896      896              
- Misses         1395     1405      +10     
  Partials         62       62              

@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review September 24, 2024 18:59
@alexander-yevsyukov alexander-yevsyukov merged commit 41d9569 into master Sep 25, 2024
7 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the actions-with-params branch September 25, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants