generated from SpineEventEngine/template
-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate to new ProtoData #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Remove duplicated dependency.
Also: * Add `pluginGroup` property. * Make `pluginLib()` private to avoid misuse in builds. * Remove deprecated properties.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
============================================
- Coverage 38.07% 37.91% -0.17%
Complexity 353 353
============================================
Files 126 125 -1
Lines 2353 2363 +10
Branches 193 195 +2
============================================
Hits 896 896
- Misses 1395 1405 +10
Partials 62 62 |
armiol
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates Validation to new package structure of ProtoData, performing conversion from the legacy types where appropriate.
The PR also sorts out the matter of using build time and compile time dependencies. It is expected that changes introduced under
buildSrc
would be later propagated toconfig
.Changes in
buildSrc
ScriptHandlerScope
got two extension values calledmcJava
andprotoData
as shortcuts for the corresponding dependency objects. Now it's possible to use these properties instead of local variables that reference the objects. Before this, we had to use the variables because imports are not yet visible underbuildScript
block.McJava
object was pulled to the package level. This way it would be easy to locate this frequently used dependency.ProtoData
object got themodule
property so that it's possible to use custom versions for aclasspath
dependency underbuildSrc
.ProtoData.pluginLib()
method was madeprivate
to avoid its misuse in the build scripts. The method only applies when using locally deployed ProtoData Gradle plugin. We do not publish the artifact with the referenced coordinates when publishing to Gradle Plugin Portal.module
build script was adjusted to useBuildSettings
object frombuildSrc
.Project.productionModules
extension was copied from McJava. We do not have the need for the extension in Validation at the moment. But it will be needed during migration to PSI-based codegen.DependencyResolution
extensions for forcing the version ofbase
were copied from McJava.Changes to the build
McJava.pluginLib
was pushed down to the modules from the root build script. This we we have the control on the versions used by production code and integration test modules.