Migrate to new Plugin API
#137
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #137 +/- ##
============================================
+ Coverage 37.91% 38.08% +0.16%
- Complexity 353 362 +9
============================================
Files 125 125
Lines 2363 2450 +87
Branches 195 195
============================================
+ Hits 896 933 +37
- Misses 1405 1455 +50
Partials 62 62 |
alexander-yevsyukov
changed the title
min_value and max_valuePlugin API
There was a problem hiding this comment.
@alexander-yevsyukov please see my comments, and let's discuss.
| @@ -59,7 +59,7 @@ protected EitherOf2<RuleAdded, Nothing> whenever(@External FieldExited event) { | |||
| var declaration = findField(event.getField(), event.getType(), event.getFile(), this); | |||
| return EitherOf2.withA(requiredRule(declaration, field)); | |||
| } | |||
| return noReaction(); | |||
| return ignoring(); | |||
There was a problem hiding this comment.
I would keep noReaction() here, as it reads better to me.
| @@ -66,7 +66,7 @@ protected EitherOf2<RuleAdded, Nothing> whenever(@External FieldExited event) { | |||
| } | |||
| var shouldValidate = field != null && field.getValidate(); | |||
| if (!shouldValidate) { | |||
| return noReaction(); | |||
| return ignoring(); | |||
| protected final EitherOf2<RuleAdded, Nothing> noReaction() { | ||
| //TODO:2024-08-11:alexander.yevsyukov: Use EventProducer.noReaction() extension from `core-java`. | ||
| return EitherOf2.withB(nothing()); | ||
| protected final EitherOf2<RuleAdded, NoReaction> ignoring() { |
There was a problem hiding this comment.
See my comments above. And let's discuss.
| // We have the option defined in the type. But is it set to `true`? | ||
| val option = event.option.value.unpack<BoolValue>() | ||
| if (!option.value) { | ||
| return EitherOf2.withB(nothing()) | ||
| return noReaction().asB() |
There was a problem hiding this comment.
This piece isn't updated, while other similar expressions are.
There was a problem hiding this comment.
@alexander-yevsyukov LGTM.
@yevhenii-nadtochii FYI. We have settled on ignore(), as noReaction() is impossible to have to return Either... instance — in the same class hierarchy it is already busy returning plain NoReaction. So there's that.
This PR migrates Validation plugins to new
PluginAPI recently introduced in ProtoData.Convenience extension functions
asA()andasB()were also adopted.