generated from SpineEventEngine/template
-
Notifications
You must be signed in to change notification settings - Fork 0
Remove java-runtime-bundle
, trim java-bundle
#166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
=========================================
Coverage 33.93% 33.93%
Complexity 344 344
=========================================
Files 137 137
Lines 2714 2714
Branches 231 231
=========================================
Hits 921 921
Misses 1730 1730
Partials 63 63 |
armiol
approved these changes
Nov 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
java-runtime-bundle
module as it's not necessary, which eliminates the issue #67.In relation to the dependency analysis performed for
java-runtime-bundle
, the size ofjava-bundle
fat JAR was reduced by leaving only the code which is produced by the Validation library. The rest is available via ProtoData classpath.Other notable changes
java-bundle
module required introduction of remaininglocal
dependency objects.Spine
andArtifactVersion
objects were deprecated in favour of new dependency objects.