Skip to content

Remove java-runtime-bundle, trim java-bundle #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Nov 30, 2024
Merged

Conversation

alexander-yevsyukov
Copy link
Collaborator

@alexander-yevsyukov alexander-yevsyukov commented Nov 29, 2024

This PR removes the java-runtime-bundle module as it's not necessary, which eliminates the issue #67.

In relation to the dependency analysis performed for java-runtime-bundle, the size of java-bundle fat JAR was reduced by leaving only the code which is produced by the Validation library. The rest is available via ProtoData classpath.

Other notable changes

  • Excluding transitive dependencies of the java-bundle module required introduction of remaining local dependency objects.
  • Properties of Spine and ArtifactVersion objects were deprecated in favour of new dependency objects.
  • Codegen dependencies were also bumped.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.93%. Comparing base (cfefc53) to head (7f5f8e8).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage     33.93%   33.93%           
  Complexity      344      344           
=========================================
  Files           137      137           
  Lines          2714     2714           
  Branches        231      231           
=========================================
  Hits            921      921           
  Misses         1730     1730           
  Partials         63       63           

Copy link
Collaborator

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alexander-yevsyukov alexander-yevsyukov merged commit f5b00d2 into master Nov 30, 2024
7 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the more-tests branch November 30, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants