Required field errors #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #170 +/- ##
============================================
+ Coverage 31.22% 33.08% +1.85%
- Complexity 331 350 +19
============================================
Files 139 139
Lines 2802 2805 +3
Branches 230 228 -2
============================================
+ Hits 875 928 +53
+ Misses 1871 1808 -63
- Partials 56 69 +13 |
Also: * Address dependency deprecations.
# Conflicts: # buildSrc/src/main/kotlin/io/spine/dependency/local/Base.kt # buildSrc/src/main/kotlin/io/spine/dependency/local/ProtoData.kt # dependencies.md # pom.xml
yevhenii-nadtochii
requested changes
Dec 18, 2024
java-tests/validating/src/testFixtures/proto/spine/test/tools/validate/required.proto
Outdated
Show resolved
Hide resolved
model/src/main/kotlin/io/spine/validation/required/RequiredPolicy.kt
Outdated
Show resolved
Hide resolved
model/src/test/kotlin/io/spine/validation/required/RequiredPolicySpec.kt
Outdated
Show resolved
Hide resolved
model/src/test/kotlin/io/spine/validation/required/RequiredPolicySpec.kt
Outdated
Show resolved
Hide resolved
model/src/testFixtures/proto/spine/validation/given/required/required_policy_spec.proto
Show resolved
Hide resolved
model/src/testFixtures/proto/spine/validation/given/required/required_policy_spec.proto
Show resolved
Hide resolved
armiol
approved these changes
Dec 18, 2024
Also: * Add more stub types.
armiol
approved these changes
Dec 18, 2024
armiol
approved these changes
Dec 18, 2024
yevhenii-nadtochii
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
RequiredPolicyto treat the(required)option applied to a boolean or number field asCompilation.Error. Now the build terminates on such an error.The PR adds the tests that verify this behaviour (see
RequiredPolicySpecfor details). Also, the PR removes the stub proto types that had wrongly applied(required)field because they now fail the build.Build changes
configwas applied.