Use placeholder-based messages in ConstraintViolation
#173
+574
−250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o return the template
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #173 +/- ##
============================================
+ Coverage 33.08% 33.77% +0.68%
- Complexity 350 351 +1
============================================
Files 139 141 +2
Lines 2805 2819 +14
Branches 228 230 +2
============================================
+ Hits 928 952 +24
+ Misses 1808 1798 -10
Partials 69 69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates
printferror message string inConstraintViolationin favor ofTemplateString. The newly created type expects a string template with${...}placeholder, and a map of placeholder values. This matches more to what we define for options within Proto definitions.Please note, the full support of recently introduced format of message placeholders is not fully implemented in this PR. This is the first step towards it.
(set_once)was migrated completely because it stands separately from theruleframework. Runtime validation was updated in a compatible way, though, as for now, we have no intention to fully support the introduced message templates. The codegen-based validation is to be migrated in the upcoming PRs.