Fix publishing #179
Merged
Fix publishing #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #179 +/- ##
=========================================
Coverage 33.55% 33.55%
Complexity 349 349
=========================================
Files 142 142
Lines 2834 2834
Branches 234 234
=========================================
Hits 951 951
Misses 1814 1814
Partials 69 69 |
|
@armiol, PTAL. |
armiol
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the version number to pass the publishing. The version was increased by mistake for the previous PR, which failed the publishing.
The
checkVersionIncrementtasks did not guard against the non-increasing the version because it did not take into account custom artifact prefix (spine-validation-) which is used for the modules of this project. This PR improves theCheckVersionIncrementtask in this regard, and the change would be propagated toconfigshortly.