Avoid false warning for wrongly applied (required) for ID fields
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
============================================
- Coverage 33.55% 33.48% -0.08%
Complexity 349 349
============================================
Files 142 142
Lines 2834 2840 +6
Branches 234 238 +4
============================================
Hits 951 951
- Misses 1814 1820 +6
Partials 69 69 |
armiol
approved these changes
Jan 8, 2025
yevhenii-nadtochii
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with false warnings reported for ID fields of command messages or entity states if a field has a type which is not compatible with the
(required)validation constraint.Also, the latest
configwas applied.