Adjust the library to the latest ProtoData #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
============================================
- Coverage 31.76% 31.65% -0.12%
Complexity 329 329
============================================
Files 142 142
Lines 2814 2818 +4
Branches 229 229
============================================
- Hits 894 892 -2
- Misses 1855 1860 +5
- Partials 65 66 +1 |
armiol
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the latest ProtoData and renames
FIELD_NAMEplaceholder toFIELD_PATH.IfInvalidwrapper has been removed. It was used only to take an error message, but(validate)doesn't have one anymore.ErrorPlaceholderandRuntimeErrorPlaceholderThese enums are identical. We use a separate version for
:java(codegen) module to prevent class clash in runtime of ProtoData. Fat JAR for ProtoData has to have:java-runtimeclasses inside because they are part of Spine. Otherwise, the app couldn't start. When the test modules invalidationtry to add the local:java-runtime, we end up with duplicate classes. Changes in the local:java-runtimemay cause compilation errors because:javawas compiled with the local:java-runtime, but ProtoData CLI uses an older version of the lib. No simple way to filter them out from a fat jar and replace with dependency on the gradle module.We have considered a separate ProtoData CLI artifact, published specifically for development of
:validation. But for this PR, we decided just to bypass the error somehow. Further migration from runtime validation incore-javamay drop the necessity to havevalidation-runtimeat all. Implementing a complex solution to a problem, which may disappear soon, is not rational.