Skip to content

Conversation

alexander-yevsyukov
Copy link
Collaborator

@alexander-yevsyukov alexander-yevsyukov commented Sep 24, 2025

This PR migrates the build to use CoreJvm Compiler. Integration tests under java-tests were restored.

Other notable changes

  • Minor improvements of buildSrc recently adopted in CoreJvm Compiler were also applied to this project.
  • Suppressed and documented deprecation warning in ValidatingOptionsLoader.

@Copilot Copilot AI review requested due to automatic review settings September 24, 2025 22:17
@alexander-yevsyukov alexander-yevsyukov self-assigned this Sep 24, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project from using the McJava compiler to the new CoreJvm Compiler, updating plugin references, dependencies, and configuration blocks throughout the codebase.

  • Updates copyright year from 2024 to 2025
  • Replaces McJava plugin references with CoreJvmCompiler across build files
  • Updates dependency versions and artifacts in Maven POM
  • Migrates configuration syntax from modelCompiler.java.codegen to spine.coreJvm.compiler

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
proto/build.gradle.kts Updates plugin classpath and plugin ID from mc-java to core-jvm
pom.xml Replaces protodata and mc-java dependencies with new compiler artifacts
java-tests/extensions/build.gradle.kts Migrates import and configuration syntax to CoreJvmCompiler
java-tests/build.gradle.kts Updates plugin import and application logic
java-runtime/build.gradle.kts Updates classpath dependency to use CoreJvmCompiler
dependencies.md Auto-generated dependency report with updated timestamps
buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvmCompiler.kt Updates version constants for the new compiler
buildSrc/src/main/kotlin/ForcePlugins.kt Migrates from mcJava to CoreJvmCompiler references
buildSrc/src/main/kotlin/BuildExtensions.kt Removes deprecated McJava shortcut extensions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Copilot Copilot AI review requested due to automatic review settings September 24, 2025 22:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review September 25, 2025 14:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 32 out of 34 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.12%. Comparing base (7fd99ec) to head (28e0f67).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #235      +/-   ##
============================================
+ Coverage     28.11%   34.12%   +6.00%     
- Complexity      201      282      +81     
============================================
  Files           129      136       +7     
  Lines          3126     3226     +100     
  Branches        246      249       +3     
============================================
+ Hits            879     1101     +222     
+ Misses         2178     2048     -130     
- Partials         69       77       +8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexander-yevsyukov alexander-yevsyukov merged commit 6f2aeff into master Sep 25, 2025
7 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the migrate-to-core-jvm-compiler branch September 25, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants