Preserve method static access for static Invokers #415
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
How did you manage to create 3 commits for such a simple change? |
Chocohead
added a commit
to Chocohead/Mixin
that referenced
this pull request
Jun 16, 2021
Reapplies FabricMC#13 Fixes FabricMC#34 Includes (a form of) SpongePowered#413 and SpongePowered#415
Chocohead
added a commit
to Chocohead/Mixin
that referenced
this pull request
Jun 16, 2021
Whilst SpongePowered#415 is generating things more correctly, there are mods (such as Better End) which rely on the current behaviour
modmuss50
pushed a commit
to FabricMC/Mixin
that referenced
this pull request
Jun 28, 2021
* Allow mixining interfaces Reapplies #13 Fixes #34 Includes (a form of) SpongePowered#413 and SpongePowered#415 * Fix mods using static vagueness Whilst SpongePowered#415 is generating things more correctly, there are mods (such as Better End) which rely on the current behaviour * Fix lambdas in interface Mixins Fixes #43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, static modifier was dropped from generated method, resulting in wrong method being generated (no static modifier).
However, bytecode was already fine, there is no aload_0, and variable offsets is ok.
TODO
Validate that
targetMethod.access & ACC_STATIC == accessorMethod.access & ACC_STATIC(Can't find where in codebase i should add this check)