Copy try-catch blocks when merging static initializers#644
Open
DaMatrix wants to merge 1 commit intoSpongePowered:masterfrom
Open
Copy try-catch blocks when merging static initializers#644DaMatrix wants to merge 1 commit intoSpongePowered:masterfrom
DaMatrix wants to merge 1 commit intoSpongePowered:masterfrom
Conversation
This also causes the merged method to work as expected if the target method contains more than one RETURN instruction.
DaMatrix
force-pushed
the
merge-clinit-try-catch-blocks
branch
from
d083c5e to
ec2d9c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change, merged exception handler code is unreachable, as the try-catch block start/end/handler information isn't copied into the target method.
This also causes the merged method to work as expected if the target method contains more than one RETURN instruction.