Move ServiceLoader.iterator.hasNext call inside the try...catch in MixinService#694
Open
AlexIIL wants to merge 1 commit intoSpongePowered:masterfrom
Open
Move ServiceLoader.iterator.hasNext call inside the try...catch in MixinService#694AlexIIL wants to merge 1 commit intoSpongePowered:masterfrom
AlexIIL wants to merge 1 commit intoSpongePowered:masterfrom
Conversation
…xinService. This is because ServiceLoader.iterator may attempt to load services during either hasNext or next, however only the second call was being handled correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is because ServiceLoader.iterator may attempt to load services during either hasNext or next, however only the second call was being caught correctly.
Similar logic should probably be applied to every call, however there's quite a few of them and only this particular one caused a crash for me.