Skip to content

Remove explict forward calls in RecurrentPPO #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
araffin merged 4 commits into from
Dec 8, 2025
Merged

Remove explict forward calls in RecurrentPPO #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
142be20
Fix: Do not call model.forward() directly!
immortal-boy Dec 7, 2025
4c22ac4
update changelog
immortal-boy Dec 7, 2025
2c59e99
Fix type hint in distributions
araffin Dec 8, 2025
b76ede6
Update changelog.rst
araffin Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/misc/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ New Features:

Bug Fixes:
^^^^^^^^^^
- Do not call ``forward()`` method directly in ``RecurrentPPO``

Deprecations:
^^^^^^^^^^^^^
Expand Down
3 changes: 2 additions & 1 deletion sb3_contrib/common/maskable/distributions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,10 @@ class MaskableCategoricalDistribution(MaskableDistribution):
:param action_dim: Number of discrete actions
"""

distribution: MaskableCategorical

def __init__(self, action_dim: int):
super().__init__()
self.distribution: MaskableCategorical | None = None
self.action_dim = action_dim

def proba_distribution_net(self, latent_dim: int) -> nn.Module:
Expand Down
2 changes: 1 addition & 1 deletion sb3_contrib/ppo_recurrent/ppo_recurrent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def collect_rollouts(
# Convert to pytorch tensor or to TensorDict
obs_tensor = obs_as_tensor(self._last_obs, self.device)
episode_starts = th.tensor(self._last_episode_starts, dtype=th.float32, device=self.device)
actions, values, log_probs, lstm_states = self.policy.forward(obs_tensor, lstm_states, episode_starts)
actions, values, log_probs, lstm_states = self.policy(obs_tensor, lstm_states, episode_starts)

actions = actions.cpu().numpy()

Expand Down