Skip to content

Fixed missing verbose parameter passing (#96) #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

BurakDmb
Copy link
Contributor

@BurakDmb BurakDmb commented Aug 14, 2022

Description

According to #96, MaskablePPO does not handle the verbose parameter in MaskableEvalCallback constructor. Therefore I opened a PR to fix this situation. Main issue and PR: DLR-RM/stable-baselines3#1006 and DLR-RM/stable-baselines3#1011

Context

  • I have raised an issue to propose this change (required)

This closes #96

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • The functionality/performance matches that of the source (required for new training algorithms or training-related features).
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have included an example of using the feature (required for new features).
  • I have included baseline results (required for new training algorithms or training-related features).
  • I have updated the documentation accordingly.
  • I have updated the changelog accordingly (required).
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

@qgallouedec qgallouedec merged commit 049f5a1 into Stable-Baselines-Team:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verbose parameter is not handled in MaskablePPO evaluation.
2 participants