Generate self-signed certificates with subject alternative name#300
Open
winem wants to merge 4 commits intoStackStorm:masterfrom
Open
Generate self-signed certificates with subject alternative name#300winem wants to merge 4 commits intoStackStorm:masterfrom
winem wants to merge 4 commits intoStackStorm:masterfrom
Conversation
Contributor
Author
|
Converted the PR to a draft until I had time to look into the CentOS7 issues Travis has. |
Contributor
|
Looks to be an idemptonency problem on centos 7, so on second run it complaisn about 2 changed tasks: The new tasks for Redhat7 as they stand will always create the temp file /tmp/openssl.cnf and delete them - so will fail the idempotency test. Perhaps add a when on the first one so that it only does it if /etc/ssl/st2/st2.key doesn't exist? |
Contributor
Author
|
Yes, that'll probably be it. I'll provide an update. |
Contributor
Author
|
I'm happy about (re-)reviews of this PR! |
5a6bf68 to
6b055b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we create self-signed certificates with an SubjectAlternativeName as requested in #293
The openssl version shipped on RedHat/CentOS7 is too old and does not support the SAN attributes to be passed on the command line so it needs an extra configuration file.
close #293