Skip to content

Update st2client.js to 1.2.2 #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Update st2client.js to 1.2.2 #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43c4e74
Update st2client.js from 1.1.3 to 1.2.2
blag Apr 21, 2020
487ae12
Bump version to 0.10.3 and update CHANGELOG
blag Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ Changelog
in development
--------------

0.10.3
------

* Update st2client.js to 1.2.2 [PR #203] (change)
Copy link
Member

@arm4b arm4b Apr 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally to indicate in the changelog that it's an update to potentially vulnerable dependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally try to avoid mentioning this, since people may scan changelogs for security updates, figure out how to attack older ST2 instances, and then start attacking older ST2 installations. The Linux kernel ran into this issue awhile back IIRC.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree.

Users should know whether specific versions of the released software had any potential security issues, fixes, mitigations or not. This could be a driving factor for them to update or not.

I don't think it's a common practice to hide this kind of information behind the vague changelog.

For example here is pip changelog https://pip.pypa.io/en/stable/news/#id302:

Upgrade the bundled copy of requests to 2.6.0, fixing CVE-2015-2296.

This changelog is related to updating pip's dependency requests which had a security issue (https://nvd.nist.gov/vuln/detail/CVE-2015-2296).


0.10.2
------

Expand Down
42 changes: 34 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "hubot-stackstorm",
"description": "A hubot plugin for integrating with StackStorm event-driven infrastructure automation platform.",
"version": "0.10.2",
"version": "0.10.3",
"author": "StackStorm, Inc. <[email protected]>",
"license": "Apache-2.0",
"keywords": [
Expand All @@ -26,7 +26,7 @@
"coffee-script": "1.12.7",
"lodash": "^4.17.11",
"rsvp": "^4.8.4",
"st2client": "^1.1.3",
"st2client": "^1.2.2",
"truncate": "^2.0.1",
"uuid": "^3.0.0"
},
Expand Down