Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.6 testing for ST2 3.9.0 #6080

Merged
merged 13 commits into from
Apr 22, 2024

Conversation

philipphomberger
Copy link

@philipphomberger philipphomberger commented Dec 4, 2023

Update Pipeline for Circleci.

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Dec 4, 2023
@philipphomberger philipphomberger marked this pull request as ready for review December 4, 2023 07:00
@nzlosh
Copy link
Contributor

nzlosh commented Jan 20, 2024

@philipphomberger Is this MR ready for merge?

@philipphomberger
Copy link
Author

@philipphomberger Is this MR ready for merge?

Yes I think so.

Would be very helpful to update the PIP dependencies in small units.

@nzlosh nzlosh requested review from cognifloyd and amanda11 January 23, 2024 09:43
@nzlosh
Copy link
Contributor

nzlosh commented Jan 23, 2024

Good stuff! Yes, we need to remove py3.6 testing to so we can start moving forward with adding mongodb and newer python versions.

Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just wondering on best order to go about this...
We still have CI pipelines and build projects that are going to build python 3.6 images.
So it might be better to merge this PR after we have stopped the st2-packages and st2packaging-dockerfiles from requiring python 3.6 images.

Might be worth doing a PR on those repos first to get rid of python 3.6 images and then merge this one.

@nzlosh
Copy link
Contributor

nzlosh commented Jan 23, 2024

There's already work underway to remove py3.6 from st2 packaging which should arrive this week or the next.

@cognifloyd
Copy link
Member

I just merged #6118 which included dropping python3.6 from GHA. Sorry I didn't see your PR, or I would have merged this first.

@pull-request-size pull-request-size bot added size/XS PR that changes 0-9 lines. Quick fix/merge. and removed size/M PR that changes 30-99 lines. Good size to review. labels Jan 29, 2024
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you move the changelog entry up to the in development section and adjust the wording to reflect the narrowed scope of this PR? Then I'll merge.

@cognifloyd cognifloyd added this to the 3.9.0 milestone Apr 19, 2024
@philipphomberger
Copy link
Author

Would you move the changelog entry up to the in development section and adjust the wording to reflect the narrowed scope of this PR? Then I'll merge.

done

@cognifloyd cognifloyd changed the title Drop Python 3.6 Support for ST2 3.9.0 Drop Python 3.6 testing for ST2 3.9.0 Apr 22, 2024
CHANGELOG.rst Outdated Show resolved Hide resolved
Co-authored-by: Jacob Floyd <[email protected]>
@cognifloyd cognifloyd enabled auto-merge April 22, 2024 15:58
@cognifloyd cognifloyd merged commit bb4e3f2 into StackStorm:master Apr 22, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS PR that changes 0-9 lines. Quick fix/merge.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants