-
-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.6 testing for ST2 3.9.0 #6080
Drop Python 3.6 testing for ST2 3.9.0 #6080
Conversation
Keyczar is deprecated. See: https://github.com/google/keyczar Critical Vunability: https://www.cve.org/CVERecord?id=CVE-2013-7459
@philipphomberger Is this MR ready for merge? |
Yes I think so. Would be very helpful to update the PIP dependencies in small units. |
Good stuff! Yes, we need to remove py3.6 testing to so we can start moving forward with adding mongodb and newer python versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am just wondering on best order to go about this...
We still have CI pipelines and build projects that are going to build python 3.6 images.
So it might be better to merge this PR after we have stopped the st2-packages and st2packaging-dockerfiles from requiring python 3.6 images.
Might be worth doing a PR on those repos first to get rid of python 3.6 images and then merge this one.
There's already work underway to remove py3.6 from st2 packaging which should arrive this week or the next. |
I just merged #6118 which included dropping python3.6 from GHA. Sorry I didn't see your PR, or I would have merged this first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you move the changelog entry up to the in development section and adjust the wording to reflect the narrowed scope of this PR? Then I'll merge.
done |
Co-authored-by: Jacob Floyd <[email protected]>
Update Pipeline for Circleci.