Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_result method to st2client #6140

Merged
merged 8 commits into from
Sep 9, 2024
Merged

Conversation

skiedude
Copy link
Contributor

In order to check the results of a given execution, this endpoint is invaluable. The get_output method can sometimes return the information, but not always.

This method will be pulling information from the /api/v1/executions/{id}/result endpoint and returns a json response

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Feb 16, 2024
@CLAassistant
Copy link

CLAassistant commented Feb 26, 2024

CLA assistant check
All committers have signed the CLA.

@guzzijones
Copy link
Contributor

please update the commit or sign the CLA for the Jacob Zufelt commit

@skiedude
Copy link
Contributor Author

skiedude commented Mar 7, 2024

@guzzijones sorry about that, fixed

@guzzijones
Copy link
Contributor

looks like the lint check failed.

@skiedude
Copy link
Contributor Author

Seems to be unrelated to my change

1. st2-auth-ldap 3.9.dev0 from git+https://github.com/StackStorm/st2-auth-ldap.git@master
    Expected sha256 hash of 29c6ff480b24e4bc316ed69eac5503c71f4700ed17649ae5c5ca8cd745e5852f when downloading st2-auth-ldap but hashed to 1b62240f8004316de753c3e2e20e629d0afb3337ea9a549f9022b4a7ba8c0499.

@skiedude
Copy link
Contributor Author

Same lint check is failing, not sure how my code change could have done this

1. st2-auth-ldap 3.9.dev0 from git+https://github.com/StackStorm/st2-auth-ldap.git@master
    Expected sha256 hash of 29c6ff480b24e4bc316ed69eac5503c71f4700ed17649ae5c5ca8cd745e5852f when downloading st2-auth-ldap but hashed to 1b62240f8004316de753c3e2e20e629d0afb3337ea9a549f9022b4a7ba8c0499.
    ```

@skiedude
Copy link
Contributor Author

@guzzijones is there more I need to do, in order to get a 2nd approver?

@skiedude
Copy link
Contributor Author

@cognifloyd can you do a 2nd review?

@skiedude
Copy link
Contributor Author

skiedude commented May 8, 2024

Is the milestone something I need to set? @cognifloyd

@guzzijones guzzijones added this to the 3.10.0 milestone May 16, 2024
@guzzijones
Copy link
Contributor

@cognifloyd pretty sure this hash is going to constantly change because it is built from master.

Engine traceback:
  in `lint` goal

ProcessExecutionFailure: Process 'Building 39 requirements for requirements.pex from the lockfiles/st2.lock resolve: PyYAML, apscheduler, argparse, ciso8601, cryptography, eventlet, flex, jinja2, jsonpath-rw, jsonschema<4,>=3, kombu, mock, mongoengine<0.24.0,>=0.21.0, networkx, orjson, orquesta@ git+https://github.com/StackStorm/[email protected], oslo.config, paramiko, pika, prance, psutil, pymongo<3.13.0,>=3.11.0, python-dateutil, python-json-logger, python-statsd, redis, requests, retrying, semver, setuptools, simplejson, six, sseclient-py, st2-auth-backend-flat-file@ git+https://github.com/StackStorm/st2-auth-backend-flat-file.git@master, st2-auth-ldap@ git+https://github.com/StackStorm/st2-auth-ldap.git@master, stevedore, tooz, zake, zstandard' failed with exit code 1.
stdout:

stderr:
There was 1 error downloading required artifacts:
1. st2-auth-ldap 3.9.dev0 from git+https://github.com/StackStorm/st2-auth-ldap.git@master
    Expected sha256 hash of 1b62240f8004316de753c3e2e20e629d0afb3337ea9a549f9022b4a7ba8c0499 when downloading st2-auth-ldap but hashed to b4bb3a51b74214607597e12a9594f10937226903d801951229ccbfe345461d51.

@cognifloyd
Copy link
Member

@cognifloyd pretty sure this hash is going to constantly change because it is built from master.

True. I will update that in my pants upgrade PR. But, this failure is in CI Job that is not yet required so, PRs can be merged without it passing.

@guzzijones guzzijones merged commit 8afc19a into StackStorm:master Sep 9, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S PR that changes 10-29 lines. Very easy to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants