pin urllib3 to version in lockfiles/st2.lock #6298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
added
infrastructure: ci/cd
maintenance
no changelog
cognifloyd
requested review from
winem,
nzlosh,
rush-skills,
guzzijones,
amanda11 and
a team
pull-request-size
bot
added
the
size/S
nzlosh
approved these changes
Feb 4, 2025
|
We should drop py3.8 asap, if not for the v3.9 release, then for the v3.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the lint CI job failure caused by a new version of urllib3 that does not support python 3.8. This is a transitive dep, so I just copied the locked version from
lockfiles/st2.lockinto our requirements files. I added it to anyin-requirements.txtthat includedrequests.