Skip to content

Add visual indicator for next button action #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

jdisho
Copy link
Member

@jdisho jdisho commented May 18, 2025

Add visual indicator for next button action

#101

♻️ Current situation & Problem

Once the necessary messages are exchanged, users are confused about which button to press next during a user sturdy.

⚙️ Release Notes

Add a pulsating effect (scaling to 1.2 and back) to the button that should be pressed next. This effect should only start after the required number of messages has been completed.

Simulator.Screen.Recording.-.iPhone.16.-.2025-05-18.at.22.13.48.mp4

📚 Documentation

N/A

✅ Testing

N/A

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@jdisho jdisho self-assigned this May 18, 2025
@jdisho jdisho added the enhancement New feature or request label May 18, 2025
@jdisho jdisho requested a review from PSchmiedmayer May 18, 2025 20:16
Copy link

codecov bot commented May 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 22.95%. Comparing base (dbeb5d6) to head (48e70a7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nterpretation/UserStudy/UserStudyChatToolbar.swift 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   23.24%   22.95%   -0.29%     
==========================================
  Files          57       57              
  Lines         624      632       +8     
==========================================
  Hits          145      145              
- Misses        479      487       +8     
Files with missing lines Coverage Δ
...nterpretation/UserStudy/UserStudyChatToolbar.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbeb5d6...48e70a7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jdisho jdisho force-pushed the user-study-ux-improvements branch from 9342f85 to ead10b5 Compare May 18, 2025 20:28
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 🚀

@jdisho jdisho enabled auto-merge (squash) May 19, 2025 07:05
@jdisho jdisho force-pushed the user-study-ux-improvements branch from ead10b5 to 48e70a7 Compare May 19, 2025 07:08
@jdisho
Copy link
Member Author

jdisho commented May 19, 2025

I think due to codecov I can't merge this PR. Did something change here about configurations? @PSchmiedmayer

@PSchmiedmayer
Copy link
Member

@jdisho There was an issue with the upload code coverage action; somehow the identifier was different than the one configured in the merge checks. The patch result is still holding us from merging but I will override it with admin permissions.

@PSchmiedmayer PSchmiedmayer merged commit 3b25a72 into main May 19, 2025
8 of 9 checks passed
@PSchmiedmayer PSchmiedmayer deleted the user-study-ux-improvements branch May 19, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants