-
Notifications
You must be signed in to change notification settings - Fork 17
update dependencies, some small restructuring #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… lukas/update-deps
@@ -983,8 +986,8 @@ | |||
isa = XCRemoteSwiftPackageReference; | |||
repositoryURL = "https://github.com/StanfordSpezi/SpeziFHIR"; | |||
requirement = { | |||
kind = upToNextMinorVersion; | |||
minimumVersion = 0.7.6; | |||
branch = "lukas/update-deps"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: switch to a properly tagged version before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this @lukaskollmer 🌟
But I need some more time to fully understand the new implementation details in the LLMonFHIRStandard
. I'll continue tomorrow with a fresh mind.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 22.95% 23.06% +0.11%
==========================================
Files 57 57
Lines 632 642 +10
==========================================
+ Hits 145 148 +3
- Misses 487 494 +7
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
@jdisho to explain the changes in a nutshell: in the past, LLMonFHIR used SpeziHealthKit's since this API has been removed, we now instead perform a custom fetch (using the depending on the authorization status, we either perform this fetch directly on launch (as part of the standard's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great; thank you for the quick fix and improvement 🚀
update dependencies, some small restructuring
♻️ Current situation & Problem
this PR updates the HealthKitOnFHIR and SpeziHealthKit dependencies to their 1.0 releases. it also makes some other small adjustments.
note: as part of this PR, LLMonFHIR loses the ability to detect clinical records being deleted from HealthKit while the app is running
⚙️ Release Notes
📚 Documentation
n/a
✅ Testing
n/a
Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: