Skip to content

switch to the SpeziFoundation+SpeziViews-based MarkdownDocument API #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 25, 2025

Conversation

lukaskollmer
Copy link
Member

@lukaskollmer lukaskollmer commented Jun 22, 2025

switch to the SpeziFoundation+SpeziViews-based MarkdownDocument API

♻️ Current situation & Problem

removes large parts of the dynamic Markdown handling API (which have been moved to StanfordSpezi/SpeziFoundation#33 and StanfordSpezi/SpeziViews#70), and instead uses the new types from the ther two packages.

⚙️ Release Notes

n/a; the API and functionality are unchanged

📚 Documentation

n/a; the API and functionality are unchanged

✅ Testing

n/a; the API and functionality are unchanged

📝 Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@lukaskollmer lukaskollmer self-assigned this Jun 22, 2025
@lukaskollmer lukaskollmer added the enhancement New feature or request label Jun 22, 2025
Copy link

codecov bot commented Jun 22, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.93%. Comparing base (8514366) to head (6f4baa0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...urces/SpeziConsent/Views/ConsentDocumentView.swift 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   80.71%   78.93%   -1.78%     
==========================================
  Files          20       19       -1     
  Lines         311      242      -69     
==========================================
- Hits          251      191      -60     
+ Misses         60       51       -9     
Files with missing lines Coverage Δ
...odel/ConsentDocument+CustomElementProcessing.swift 100.00% <100.00%> (ø)
.../SpeziConsent/Model/ConsentDocument+Elements.swift 92.31% <100.00%> (ø)
...es/SpeziConsent/Model/ConsentDocument+Export.swift 84.62% <ø> (ø)
Sources/SpeziConsent/Model/ConsentDocument.swift 90.00% <100.00%> (+0.72%) ⬆️
...urces/SpeziConsent/Views/ConsentDocumentView.swift 82.36% <80.00%> (-5.88%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8514366...6f4baa0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukaskollmer lukaskollmer changed the title switch to the SpeziFoundation+SpeziViews-based MarkdownDocumen API switch to the SpeziFoundation+SpeziViews-based MarkdownDocument API Jun 22, 2025
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thank you for all the improvements 👍

@lukaskollmer lukaskollmer moved this from Backlog to In Progress in Project Planning Jun 23, 2025
@lukaskollmer lukaskollmer merged commit 6246746 into main Jun 25, 2025
15 of 16 checks passed
@lukaskollmer lukaskollmer deleted the lukas/MarkdownDocument branch June 25, 2025 13:03
@github-project-automation github-project-automation bot moved this from In Progress to Done in Project Planning Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants