generated from StanfordBDHG/SwiftPackageTemplate
-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Task model using SwiftData and Schedule creation using Calendar Recurrence Rule #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for simplifications
Supereg
changed the title
Infinity Loop
New Task model using SwiftData and Schedule creation using Calendar Recurrence Rule
Sep 10, 2024
This was
linked to
issues
Sep 10, 2024
Closed
1 task
PSchmiedmayer
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the work in this PR; amazing job!!
It would be amazing to update the README accordingly and address the smaller comments I had in the PR review. A huge step toward improving on the Scheduler module; amazing job!
Tests/SpeziSchedulerUITests/__Snapshots__/SpeziSchedulerUITests/testInstructionsTile.action.png
Outdated
Show resolved
Hide resolved
…tionTile initializers
Supereg
added a commit
that referenced
this pull request
Oct 29, 2024
# Support for scheduling notifications ## ♻️ Current situation & Problem The newly introduced SpeziScheduler #44 didn't include support for notifications (see #45). This PR adds back this feature, providing several improvements over the previous implementation. A core challenge is that Apple limits the amount of locally scheduled notifications to 64 request at a time. Therefore, we optimize scheduling by applying the overall rules: * Schedules that can be expressed using repeating calendar-based notification triggers are scheduled that way, only ever occupying one request for all its event occurrences. * Otherwise, each event is scheduled individually using an interval-based trigger. In this case we order notification request by event occurrence. Further, we never schedule more than `30` notification at a time and never earlier than 1 month in advance to ensure other modules are still able to schedule local notifications. These settings can be adjusted by manually configuring the `SchedulerNotifications` in your `SpeziAppDelegate` * Scheduled Notifications are updated using background tasks (if necessary). We schedule a background task every week (or earlier if necessary) to update the scheduled notification requests. ## ⚙️ Release Notes * More advanced notification scheduling that tries to reduce the amount of notification request by using repeating notifications triggers (when using the `daily` and `weekly` shorthand initializes of a `Schedule`) and prioritizes event notifications by their occurrence date. * Automatically schedule events as time-sensitive notification if their duration is not `allDay`. * All Task Notifications are automatically put into the same Scheduler group. * Support notification content customization by conforming your Standard to the `SchedulerNotificationsConstraint`. * Automatically present notifications while the app is running in foreground (customize this using the `notificationPresentation` option). * Automatically request provisional notification authorization to schedule notification even without explicit authorization (customize this with the `automaticallyRequestProvisionalAuthorization` option). * A lot of other fixes and improvements. ## 📚 Documentation Added a dedicated configuration section around notifications in the documentation catalog. The documentation of the `SchedulerNotifications` module highlights the necessary steps to set up notifications for your project. ## ✅ Testing Added the `XCTSpeziScheduler` target that provide UI components to visualize scheduled notification requests. We use this in the UI tests to verify that notifications are scheduled as expected. The Test App schedules a repeating daily notification that has its first occurrence 40s after app launch. Additionally we schedule a daily repeating task that starts 1 week after initial app launch to test event-level scheduling. ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Task model using SwiftData and Schedule creation using Calendar Recurrence Rule
♻️ Current situation & Problem
This PR completely rethinks the Scheduler package.
We introduce an updated Task model that is completely backed by SwiftData. Further, we provide a new
Schedule
model that provides greater flexibility for formulating recurring events. Instead of formulating events based on intervals usingDateComponents
, we use the newRecurrenceRule
infrastructure introduced with iOS 18.Using a
Schedule
, you can generate a potentially infinite list ofOccurrence
s. ATask
uses the occurrences of its Schedule to generateEvents
. When events are marked as completed, they are associated with anOutcome
. Both aTask
and anOutcome
can be extended with arbitrary data. This is enabled using the@Property
macro, that allows to define custom properties on tasks and outcomes using aSharedRepository
-backed storage implementation.Task
are stored in an versioned, append-only store. Modifying the contents of a Task (e.g., instructions, schedules, ...), appends a new Task version and marks it as effective for the specified date. This allows to modify tasks without changing previous events or occurrences. Something that was impossible with the previous implementation.Lastly, the updated Scheduler provides additional support for UI components out of the box. We provide the new
@EventQuery
property wrapper that you can use in your SwiftUI views. It allows to easily and efficiently query Events directly in SwiftUI.Additionally, we provide several, reusable UI components out of the box to visualize events in your application.
Notifications are currently no longer supported with this version of SpeziScheduler: #45 (This is now tackled in #49 which will most likely be merged alongside this PR).
An example of how to configure tasks with this new model is depicted below:
⚙️ Release Notes
@EventQuery
property wrapper to easily query events in your SwiftUI view.Breaking Changes
📚 Documentation
The documentation catalog was completely restructured, highlighting all the new API and functionality.
✅ Testing
New unit and UI tests have been written to verify functionality. We aimed to set a focus on unit tests for fastest possible test execution.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: