Skip to content

fix: replace removed class aliases #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2025
Merged

Conversation

SomeMWDev
Copy link

@SomeMWDev SomeMWDev commented Jul 1, 2025

The class aliases for Html and Title were removed in MW 1.44.
Use namespaced imports instead.
Raise the MW requirement to MW 1.43.
Remove the PHP requirement since MW 1.43 required PHP 8.1.

@edg-l
Copy link

edg-l commented Jul 8, 2025

tested it and it works

@octfx octfx changed the base branch from master to develop July 8, 2025 16:11
@octfx
Copy link
Member

octfx commented Jul 8, 2025

Hm is there another way of fixing this?

1.39 is still supported until November 2025 only then should we increase the version requirement.

@SomeMWDev
Copy link
Author

Hm is there another way of fixing this?

1.39 is still supported until November 2025 only then should we increase the version requirement.

Could probably do an if/else and then manually declare the class aliases if they don't exist: https://github.com/ProfessionalWiki/chameleon/blob/1d2d3f1ab61ce9e1f81b54a3b16cd26a0baaf0f2/src/Chameleon.php#L190-L197

@alistair3149
Copy link
Collaborator

Hm is there another way of fixing this?
1.39 is still supported until November 2025 only then should we increase the version requirement.

Could probably do an if/else and then manually declare the class aliases if they don't exist: https://github.com/ProfessionalWiki/chameleon/blob/1d2d3f1ab61ce9e1f81b54a3b16cd26a0baaf0f2/src/Chameleon.php#L190-L197

The alias method isn't great too as it'll leak out to other extensions/skins. It might be better to just mark a release and drop 1.39 support, then move to 1.43 (current LTS)

@Aeywoo
Copy link

Aeywoo commented Jul 25, 2025

REL1_39 support is officially ending in November, that is only two months away, so yeah, I say it's reasonable to just drop REL1_39 support and bump to latest LTS to fix this.

@SomeMWDev
Copy link
Author

Updated the PR accordingly to only support 1.43.
There might be more deprecated but not-yet removed class aliases that could also be removed, although this is optional for now. I might look into those later if I have time

@octfx
Copy link
Member

octfx commented Jul 27, 2025

Would you be so kind and remove the version bump?
I'll changes this when merging to master 🙂

The class aliases for Html and Title were removed in MW 1.44.
Use namespaced imports instead.
Raise the MW requirement to MW 1.43.
Remove the PHP requirement since MW 1.43 required PHP 8.1.
@SomeMWDev
Copy link
Author

Would you be so kind and remove the version bump? I'll changes this when merging to master 🙂

This was caused by the target branch change so I had to git rebase upstream/develop and manually remove a commit (there's probably an easier solution), done

@octfx octfx merged commit 696c2cf into StarCitizenWiki:develop Jul 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants