-
Notifications
You must be signed in to change notification settings - Fork 21
fix: replace removed class aliases #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tested it and it works |
Hm is there another way of fixing this? 1.39 is still supported until November 2025 only then should we increase the version requirement. |
Could probably do an if/else and then manually declare the class aliases if they don't exist: https://github.com/ProfessionalWiki/chameleon/blob/1d2d3f1ab61ce9e1f81b54a3b16cd26a0baaf0f2/src/Chameleon.php#L190-L197 |
The alias method isn't great too as it'll leak out to other extensions/skins. It might be better to just mark a release and drop 1.39 support, then move to 1.43 (current LTS) |
REL1_39 support is officially ending in November, that is only two months away, so yeah, I say it's reasonable to just drop REL1_39 support and bump to latest LTS to fix this. |
Updated the PR accordingly to only support 1.43. |
Would you be so kind and remove the version bump? |
The class aliases for Html and Title were removed in MW 1.44. Use namespaced imports instead. Raise the MW requirement to MW 1.43. Remove the PHP requirement since MW 1.43 required PHP 8.1.
This was caused by the target branch change so I had to |
The class aliases for Html and Title were removed in MW 1.44.
Use namespaced imports instead.
Raise the MW requirement to MW 1.43.
Remove the PHP requirement since MW 1.43 required PHP 8.1.