Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support jodatime_format function to partition pruning #52620

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

renzhimin7
Copy link
Contributor

@renzhimin7 renzhimin7 commented Nov 5, 2024

Why I'm doing:

  1. hive 外表testDb.testTable 分区字段是dt ,有6个分区
    dt=20241101
    dt=20241102
    dt=20241103
    dt=20241104
    dt=20241105
    dt=20241106
  2. 在执行下面SQL时,无法执行分区裁剪
    select * from flight.zhimin_t where dt = jodatime_format('2024-11-02 15:58:51', 'yyyyMMdd')
image

What I'm doing:

增加jodatime_format转换方法
验证可以裁剪
image

Fixes #52680

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@renzhimin7 renzhimin7 changed the title Support jodatime_format function to partition pruning [Feature] Support jodatime_format function to partition pruning Nov 5, 2024
Astralidea
Astralidea previously approved these changes Nov 5, 2024
Seaven
Seaven previously approved these changes Nov 6, 2024
@Astralidea Astralidea enabled auto-merge (squash) November 6, 2024 19:01
auto-merge was automatically disabled November 7, 2024 04:36

Head branch was pushed to by a user without write access

@renzhimin7 renzhimin7 dismissed stale reviews from Seaven and Astralidea via 76f878b November 7, 2024 04:36
trueeyu
trueeyu previously approved these changes Nov 7, 2024
Seaven
Seaven previously approved these changes Nov 7, 2024
@trueeyu
Copy link
Contributor

trueeyu commented Nov 7, 2024

@Mergifyio rebase main

Copy link
Contributor

mergify bot commented Nov 7, 2024

rebase main

✅ Branch has been successfully rebased

@trueeyu
Copy link
Contributor

trueeyu commented Nov 8, 2024

https://github.com/Mergifyio rebase main

Copy link
Contributor

mergify bot commented Nov 8, 2024

rebase main

❌ Base branch update has failed

Git reported the following error:

Rebasing (1/7)
Rebasing (2/7)
Rebasing (3/7)
Rebasing (4/7)
Rebasing (5/7)
Rebasing (6/7)
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git rebase --skip'
interactive rebase in progress; onto b8447fb44
Last commands done (6 commands done):
   pick ef9b87550 Support jodatime_format function to partition pruning
   pick f0cd76f30 Support jodatime_format function to partition pruning
  (see more in file .git/rebase-merge/done)
Next command to do (1 remaining command):
   pick ac1590bc7 Support jodatime_format function to partition pruning
  (use "git rebase --edit-todo" to view and edit)
You are currently rebasing branch 'renzhimin7-main' on 'b8447fb44'.
  (all conflicts fixed: run "git rebase --continue")

nothing to commit, working tree clean
Could not apply f0cd76f30... Support jodatime_format function to partition pruning

Copy link

github-actions bot commented Nov 8, 2024

[FE Incremental Coverage Report]

fail : 7 / 12 (58.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java 7 12 58.33% [415, 420, 421, 426, 428]

Copy link

github-actions bot commented Nov 8, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 8, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

sonarcloud bot commented Nov 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support jodatime_format function to partition pruning
4 participants