Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix]better bit upacking batch size #52701

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

zombee0
Copy link
Contributor

@zombee0 zombee0 commented Nov 7, 2024

Why I'm doing:

bit unpacking with simd process data with batch, so there may be out of bound access,
we need check the batch_size to avoid out-of-bound access which leads to crash in asan mode.
and make specific logic for bit_width between 22 and 24.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@zombee0 zombee0 requested a review from a team as a code owner November 7, 2024 10:46
@mergify mergify bot assigned zombee0 Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 7, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 7, 2024

[BE Incremental Coverage Report]

fail : 3 / 28 (10.71%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/util/bit_packing_simd.h 0 25 00.00% [266, 268, 270, 271, 272, 273, 274, 276, 279, 280, 281, 282, 284, 285, 286, 287, 288, 289, 291, 292, 294, 297, 459, 460, 468]
🔵 be/src/util/bit_packing_adapter.h 3 3 100.00% []

@andyziye andyziye merged commit fa3d2b0 into StarRocks:main Nov 11, 2024
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants