Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] support del files and cloud native index recover for shared-data pk table #52707

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Nov 7, 2024

Why I'm doing:

Primary key table recover is used for the case that PK table meet inconsistent issue, error message like:

"insert found duplicate key"
"unexpected segment id"
"delvec inconsistent"

and we need to auto recover from this issue by rebuild PK index and delete vector.
But in current implementation, it doesn't support:

  1. recognize deletion files
  2. cloud native index rebuild

So in this PR we want to fix these.

What I'm doing:

This pull request includes several enhancements and bug fixes related to the primary key recovery mechanism in the shared-data mode. The changes include improvements to PK table recover capability, the addition of test hooks for recovery scenarios, and updates to unit tests to cover new recovery cases.

Enhancements to metadata handling:

Addition of test hooks:

Updates to unit tests:

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@luohaha luohaha requested a review from a team as a code owner November 7, 2024 13:06
@luohaha luohaha changed the title [Enhancement] support del files recover and cloud native index recover for shared-data pk table [Enhancement] support del files and cloud native index recover for shared-data pk table Nov 7, 2024
Copy link

github-actions bot commented Nov 8, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 8, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 8, 2024

[BE Incremental Coverage Report]

pass : 29 / 29 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/meta_file.cpp 5 5 100.00% []
🔵 be/src/storage/lake/lake_primary_key_recover.cpp 19 19 100.00% []
🔵 be/src/storage/lake/update_manager.cpp 5 5 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant