[Enhancement] Reduce metadata lock scope for files() schema pushdown (backport #63796) #63940
+71
−64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Schema inference for files() (filesystem listing + backend RPC) previously executed while holding DB/table metadata locks during analysis, amplifying lock contention and planning latency under slow or remote storage.
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Moves schema pushdown locking into a short-lived table READ lock and simplifies Insert analysis flow outside locks.
analyzeWithDeferredLock
: performs properties analysis, files() schema pushdown, and query analysis without holding planner/meta locks; removes conditional lock-taking logic.Database
and target table ID; withinpushDownSchemaFunc
acquiresLocker
READ lock on the table, reloads session-aware table, applies column mapping, then unlocks.Locker
/LockType
usage to replace broader planner/meta lock during files() schema inference.Written by Cursor Bugbot for commit d102414. This will update automatically on new commits. Configure here.
This is an automatic backport of pull request #63796 done by [Mergify](https://mergify.com).