Proposal of tweaks around global and local cache configuration #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdybicz
commented
Jul 1, 2022
•
kdybicz
commented
- Making sure global cache configuration is taken into consideration for all datasource methods
- Making sure method-specific cache configuration is overriding global configuration, if present
- Adding related tests
- Adding VSC configuration folder to .gitignore
|
@StarpTech I'm happy to talk through the changes I've made and the motivation, I also have following changes queued up, ie. for optional |
StarpTech
requested changes
Aug 27, 2022
.vscode/launch.json
Outdated
| @@ -0,0 +1,20 @@ | |||
| { | |||
There was a problem hiding this comment.
Please remove .vscode files and add them to the .gitignore file.
|
Hi @kdybicz sorry for the late response. Your change will give request options precedence over global defaults. This is natural and the current behavior was more of a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.