-
Notifications
You must be signed in to change notification settings - Fork 5
Kf1.9(jupyter): fix i18n #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* updated common lib package-lock file * fixed some vulns for jupyter * updated overrides for common lib * updated overrides for jupyter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, LGTM
frontend/common/kubeflow-common-lib/projects/kubeflow/src/lib/form/validators.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense for aaw, not the zone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the first one is using it, I figured there was no hurt in finishing the rest. This being said this specific thing doesn't show correctly when local build. Creating a ticket to fix it.
https://jirab.statcan.ca/browse/BTIS-674