Skip to content

Kf1.9(jupyter): fix i18n #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 1, 2025
Merged

Kf1.9(jupyter): fix i18n #353

merged 11 commits into from
Apr 1, 2025

Conversation

wg102
Copy link
Contributor

@wg102 wg102 commented Mar 25, 2025

wg102 and others added 5 commits March 25, 2025 16:01
* updated common lib package-lock file

* fixed some vulns for jupyter

* updated overrides for common lib

* updated overrides for jupyter
@wg102 wg102 changed the title Kf1.9(jupyter): fix i19n Kf1.9(jupyter): fix i18n Mar 25, 2025
@wg102 wg102 added the auto-deploy Trigger manual CI steps for this CI label Mar 25, 2025
Copy link
Contributor

@Souheil-Yazji Souheil-Yazji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense for aaw, not the zone

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the first one is using it, I figured there was no hurt in finishing the rest. This being said this specific thing doesn't show correctly when local build. Creating a ticket to fix it.

@wg102 wg102 merged commit 3331390 into KF1.9-jupyter-apis Apr 1, 2025
6 checks passed
@wg102 wg102 deleted the kf1.9-fix-i18n branch April 1, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-deploy Trigger manual CI steps for this CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants