Skip to content

chore(ulimit): set to 0 for core dumps #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 5, 2025
Merged

chore(ulimit): set to 0 for core dumps #51

merged 5 commits into from
May 5, 2025

Conversation

Jose-Matsuda
Copy link
Contributor

For https://jirab.statcan.ca/browse/BTIS-842
Just setting to 0, according to the man page,

When setting new limits, if neither '-H' nor '-S' is supplied, both the hard and soft limits are set.

@Jose-Matsuda Jose-Matsuda added the auto-deploy Trigger manual CI steps for this PR label Apr 29, 2025
@Jose-Matsuda
Copy link
Contributor Author

Jose-Matsuda commented Apr 30, 2025 •
edited
Loading

image
and
image

Just having the RUN ulimit... in the dockerfile fails, so I added it to the startup script instead.

@Jose-Matsuda Jose-Matsuda changed the title Set ulimit chore(ulimit): set to 0 for core dumps Apr 30, 2025
mathis-marcotte
mathis-marcotte previously approved these changes May 1, 2025
View reviewed changes
Copy link
Collaborator

@mathis-marcotte mathis-marcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a small comment on the pr.

Tested with artifactory.cloud.statcan.ca/das-aaw-docker/jupyterlab-cpu:c11476d2

Seeing the core file size set to 0
image

mathis-marcotte
mathis-marcotte approved these changes May 1, 2025
View reviewed changes
Copy link
Collaborator

@mathis-marcotte mathis-marcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 2.0

@Jose-Matsuda Jose-Matsuda merged commit f29f860 into master May 5, 2025
27 checks passed
@Jose-Matsuda Jose-Matsuda deleted the set-ulimit branch May 5, 2025 11:22
bryanpaget pushed a commit that referenced this pull request May 13, 2025
@Jose-Matsuda @bryanpaget
chore(ulimit): set to 0 for core dumps (#51)
a110d74 
* chore ulimit -c 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathis-marcotte mathis-marcotte mathis-marcotte approved these changes

Assignees
No one assigned
Labels
auto-deploy Trigger manual CI steps for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jose-Matsuda @mathis-marcotte