Resolve Slow-Motion Video and Output Size Issues in video_detect Function #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove tensorrt execution
update available_providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two main issues in the video_detect function:
Slow-Motion Output: The output video sometimes played in slow motion due to variable frame rate handling inconsistencies.
Reduced Output Size: Output videos experienced a significant size reduction, which impacted video quality in some cases.
Key Changes:
Frame Rate Consistency: Integrated OpenCV for reading the video, which ensures a consistent frame rate (fps) throughout the processing, eliminating slow-motion playback. Added a fallback to 30 fps in case of an invalid frame rate, improving compatibility across diverse input videos.
Enhanced Metadata and Quality Preservation: Included the -map_metadata 0 option in FFmpeg configuration to retain metadata from the input file, which helps preserve original color profiles and other settings. Dynamically set the pixel format based on the input video to ensure compatibility and consistency with the input format, which also helped maintain quality. Improved bitrate management by setting the output bitrate to match the input bitrate, if available, and established a default if extraction fails. This adjustment helps maintain video quality and reduces drastic size changes. Added support for audio codec copying and transcoding as needed, providing flexibility in retaining or converting audio to match various requirements.