Make Updater weak_ptr and add const/style fixes #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace shared_ptr<Updater> with weak_ptr and guard progress dispatches with .lock(). Mark several APIs const or static and tighten parameter types. Reorder headers, prefer free filesystem helpers (exists/create_directories), and clean up minor style issues. Fix plugin install path handling and correct inline documentation in theme_mgr.h. Signed-off-by: Toria <[email protected]>
Member
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace shared_ptr with weak_ptr and guard progress dispatches with .lock(). Mark several APIs const or static and tighten parameter types. Reorder headers, prefer free filesystem helpers (exists/create_directories), and clean up minor style issues. Fix plugin install path handling and correct inline documentation in theme_mgr.h.