Fix KiriKiri detection #147
Merged
+6
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked there's some games that have data.xp3 in a folder. |
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SteamDB app page links to a few games using this
(not relevant as this updates an existing detection)
Brief explanation of the change
This should fix #128 and other detection issues for the KiriKiri engine by replacing rules with a far simpler one: its games always ship with a file called
data.xp3, the extension being unique enough that googling it brings up only KiriKiri-related results.The existing detections are not guaranteed to be present in KiriKiri games, resulting in false negatives, and, in the case of
wuvorbis.dll, might be present in games that do not use this engine, resulting in false positives.