allow older windows-sys 0.52 #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot bumped the version to 0.59 but older version 0.52 can also be supported allowing upstream crates to pull dependency as per their version choice.
Owner
|
Why? |
Contributor
Author
|
I don't think tempfile makes use of any API change which might have been introduced with |
Owner
|
Hm. There's no guarantee that'll work as you expect (rust-lang/cargo#10599) but it's unlikely to hurt given that this dependency isn't exported. |
Stebalien
approved these changes
Nov 5, 2024
Contributor
Author
|
Yep the resolver can't really make out of this NP hard problem but many a times it works and gets the right one. |
Owner
|
3.14 published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependabot bumped the version to 0.59 but older version 0.52 can also be supported allowing downstream crates to pull dependency as per their version choice.