Skip to content

Feat: Frontend #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Apr 7, 2025
Merged

Feat: Frontend #544

merged 30 commits into from
Apr 7, 2025

Conversation

Kohulan
Copy link
Member

@Kohulan Kohulan commented Apr 2, 2025

No description provided.

@Kohulan Kohulan requested a review from Copilot April 2, 2025 21:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces significant frontend additions for a cheminformatics microservice UI and updates documentation and configuration. Key changes include:

  • Addition of multiple React components to support chemical analysis, descriptor calculation, structure validation, and more
  • Integration of new routes and layout improvements in App.js, along with updates to README.md and PostCSS configuration

Reviewed Changes

Copilot reviewed 56 out of 62 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
frontend/src/components/common/Header.jsx New header component with animation and theme toggle functionality
frontend/src/components/chem/TanimotoView.jsx Component for calculating Tanimoto similarity using API calls
frontend/src/components/chem/StructureErrorView.jsx Component for structure validation with error feedback
frontend/src/components/chem/StereoisomersView.jsx Component to generate and display stereoisomers
frontend/src/components/chem/StandardizedTautomerView.jsx Component for generating standardized tautomers
frontend/src/components/chem/StandardizeView.jsx Component for molecule standardization via molblock input
frontend/src/components/chem/NPlikenessView.jsx Component to calculate and display NP-likeness score
frontend/src/components/chem/HOSECodeView.jsx Component for generating and displaying HOSE codes
frontend/src/components/chem/ErtlFunctionalGroupView.jsx Component for detecting functional groups with the Ertl algorithm
frontend/src/components/chem/DescriptorsView.jsx Component for calculating and presenting molecular descriptors
frontend/src/components/chem/CoconutPreProcessingView.jsx Component for pre-processing molecules for COCONUT submission
frontend/src/App.js App routing and layout including header/footer and not found page
frontend/postcss.config.js Configuration update with TailwindCSS and autoprefixer
README.md Updated documentation and badges
Files not reviewed (6)
  • frontend/.gitignore: Language not supported
  • frontend/Dockerfile: Language not supported
  • frontend/LICENSE.txt: Language not supported
  • frontend/package.json: Language not supported
  • frontend/public/index.html: Language not supported
  • frontend/public/manifest.json: Language not supported
Comments suppressed due to low confidence (1)

frontend/src/components/chem/ErtlFunctionalGroupView.jsx:43

  • Consider using a more explicit check for the absence of functional groups instead of relying on 'groupsArray[0]?.None'. For example, check if the property 'None' exists using the 'in' operator or use a dedicated flag to indicate no groups found.
if (groupsArray.length === 0 || (groupsArray.length === 1 && groupsArray[0]?.None)) {

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 88.07947% with 18 lines in your changes missing coverage. Please review.

Project coverage is 92.00%. Comparing base (854fa41) to head (4fe89cb).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
app/routers/chem.py 21.73% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
+ Coverage   91.61%   92.00%   +0.39%     
==========================================
  Files          47       50       +3     
  Lines        2792     3141     +349     
==========================================
+ Hits         2558     2890     +332     
- Misses        234      251      +17     
Flag Coverage Δ
service 92.00% <88.07%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kohulan Kohulan requested a review from Copilot April 2, 2025 21:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a comprehensive frontend implementation for the Cheminformatics Microservice UI. Key changes include new components for chemical property calculations (e.g. Tanimoto similarity, NP-likeness, HOSE codes, Ertl functional groups, descriptors), pre‐processing for COCONUT submissions, and updates to the application layout and README.

Reviewed Changes

Copilot reviewed 56 out of 62 changed files in this pull request and generated no comments.

Show a summary per file
File Description
frontend/src/components/common/Header.jsx Adds the Header component with animated UI elements and navigation
frontend/src/components/chem/*.jsx Introduces multiple chemistry-related views for structure validation, scoring, descriptor calculation, etc.
frontend/src/App.js Sets up routing and layout for the updated UI
README.md Updates documentation and badges reflecting enhanced frontend features
Other config files (postcss.config.js, etc.) Minor project configuration updates
Files not reviewed (6)
  • frontend/.gitignore: Language not supported
  • frontend/Dockerfile: Language not supported
  • frontend/LICENSE.txt: Language not supported
  • frontend/package.json: Language not supported
  • frontend/public/index.html: Language not supported
  • frontend/public/manifest.json: Language not supported
Comments suppressed due to low confidence (2)

frontend/src/components/common/Header.jsx:18

  • [nitpick] Consider renaming the parameter 'i' to a more descriptive name (e.g., 'staggerIndex') to improve code clarity; also ensure that the default parameter assignment is intentional.
visible: (i = 1) => ({

frontend/src/App.js:38

  • Consider replacing the anchor tag with a Link component from react-router-dom to enable client-side routing and improve navigation performance in the SPA.
    <a href="/" className="...">

@Kohulan Kohulan changed the title Development Feat: Frontend Apr 7, 2025
@Kohulan Kohulan requested a review from vcnainala April 7, 2025 08:57
@vcnainala vcnainala merged commit ae2d163 into main Apr 7, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get SMILES from name using Pubchem fix the murcko framework spelling
2 participants