Skip to content

Sky culture converter20062025 #4385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 67 commits into from
Closed

Sky culture converter20062025 #4385

wants to merge 67 commits into from

Conversation

MherMnatsakanyan03
Copy link

No description provided.

RivinHD and others added 30 commits May 1, 2025 12:33
@RivinHD
Adjusted for MinGW compilation (#20)
6977849
@Integer-Ctrl
Merge branch 'Stellarium:master' into master
c632288
@xLPMG
feat: create SCM plugin and add line drawing tool (#14)(#15) (#21)
9f8435b
@Integer-Ctrl
Merge branch 'Stellarium:master' into master
3a12db3
@RivinHD
Create bundle-build.yml
9abd2ac
@RivinHD
Update bundle-build.yml
dcc1df4
@RivinHD
Update bundle-build.yml
1db3fb8
@RivinHD
Update bundle-build.yml
ea0df59
@RivinHD
Update bundle-build.yml
0c15ca0
@RivinHD
Stellarium bundeling Action (#46)
4ae6344 
* Switched to bundel MSVC

Added windows mingw to ci

* Fixed vcpkg install

* Update bundle-build.yml

* Fixed workflows

* Swichted to poweshell & vcpkg not requiered

* Removed windows ci

* Added new icons

* Revert "Added new icons"

This reverts commit 9ff982a.

* Update bundle-build.yml

* Removed zipped does not work

* Update bundle-build.yml

* don't create a desktop icon
@xLPMG
feat: Basic workflow implementation (#33)
19fbfcc 
yippieeee
@RivinHD
Merge branch 'master' into sync-fork
9818306
@RivinHD
Sync from master
e9f9036
@RivinHD
chore: split bundle steps
f15dcbb
@RivinHD
feat: Implemented erase
e676fbc
@RivinHD
chore: cleanup
1c06dae
@RivinHD
chore: cleanup
b2ed260
@RivinHD
chore: qt5 support
03d7f62
@RivinHD
feat: added support for immediate connect on search
212fb9c
@xLPMG
implement basic features
8992765
@xLPMG
misc
5dcd476
@xLPMG
improve layout of SkyCultureDialog
359601d
@xLPMG
fix minor UI details
3f9f1d7
@xLPMG
fix code doc and that the selected tool was not reset after saving co…
a494cf7 
…nstellation
@RivinHD
fix: missing end point on findNearestPoint
c8ae3c4
@Integer-Ctrl
fix: pr suggestions
ba2a88c
@Integer-Ctrl
Merge pull request #67 from Integer-Ctrl/56-feature-eraser-for-stick-…
dafc56a 
…figure-lines

feat: eraser for stick figure lines (#56)
@xLPMG
fix removal of constellations didnt remove all drawn lines
a0124e1
@RivinHD
fix: typo
4aafc3e
@Integer-Ctrl
Merge pull request #71 from Integer-Ctrl/52-displayConstellationsInSC…
585cde6 
…Overview

feat: Display constellations in SC Overview and make constellations removable (#52)(#53)
Integer-Ctrl and others added 24 commits June 15, 2025 12:03
@Integer-Ctrl
ui: form
2b66bcb
@Integer-Ctrl
Merge pull request #83 from Integer-Ctrl/82-export-constellations
202b9e6 
feat: implement constellation json export (#82)
@Integer-Ctrl
feat: description form + force user to complete form + save as markdown
cd30fdf
@Integer-Ctrl
Merge branch 'master' into 9-upload-text-and-images-for-description-md
4bb4b5a
@Integer-Ctrl
fix: pr suggestions
485f643
@Integer-Ctrl
chore: merge
48b983f
@Integer-Ctrl
Merge pull request #84 from Integer-Ctrl/9-upload-text-and-images-for…
facc6f8 
…-description-md

9 upload text and images for description md
@RivinHD
76 bug save a constellation results in fatal assert on windows (#86)
1397b83 
* fix: assertion + perf: less value copies

The assertion was a result because the SPainter was passed by value i.e. copied and not passed by reference

* chore: merge mistake from main stellarium

* fix: merge mistakes

* chore: improved function signatures

* fix: update error handling

* chore: cleanup

* fix: label not drawn
@xLPMG
fix: use nameColor in drawNames (#96)
7dd05c1
@xLPMG
Merge remote-tracking branch 'upstream/master'
689785c
@MherMnatsakanyan03
Merge branch 'Stellarium:master' into master
6e4c9fa
@MherMnatsakanyan03
Added SkyCultureConverter as extra button
b40431a
@MherMnatsakanyan03
Add gettextpo and libtidy to windows build
e68e9b3
@MherMnatsakanyan03
Pin vcpkg to a specific commit for reproducible builds
cbffaf4
@MherMnatsakanyan03
Update vcpkg commit ID
a440c3d
@MherMnatsakanyan03
reverted ci changes since scc was updated
ecaecac
@MherMnatsakanyan03
Update vcpkg setup with specific commit ID and adjust dependencies
f2152d8
@MherMnatsakanyan03
attempt to fix bundle-build
faf5603
@MherMnatsakanyan03
Update bundle-build workflow to specify vcpkg commit ID and remove un…
9c8d68d 
…used CMake step
@MherMnatsakanyan03
Update vcpkg install command to specify architecture for dependencies
3bac9bd
@MherMnatsakanyan03
Update bundle-build workflow to use x64 architecture for dependencies…
0143a7b 
… and adjust CMake configuration
@MherMnatsakanyan03
tried to fix toolchain path
6671929
@MherMnatsakanyan03
ignore scm because dependencie installation doesnt work
9a25dc9
@MherMnatsakanyan03
only disable the scc instead of scm entirely
77d158e
@github-actions github-actions bot requested review from 10110111, alex-w and gzotti June 21, 2025 11:21
@MherMnatsakanyan03
Copy link
Author

  • Added SkyCultureConverter via "convert" button in start dialog

  • option to disable it via "-DSCM_SHOULD_ENABLE_CONVERTER=Off"

  • automatic disabling when Qt Version 5

  • convertion happens in parrallel thread, so that ui-thread is not stuck possibly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@10110111 10110111 Awaiting requested review from 10110111

@alex-w alex-w Awaiting requested review from alex-w

@gzotti gzotti Awaiting requested review from gzotti

Assignees

@MherMnatsakanyan03 MherMnatsakanyan03

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MherMnatsakanyan03 @RivinHD @Integer-Ctrl @xLPMG @ZeyxRew