Skip to content

Increase duration from 100 -> 1000 units of time #4416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

Atque
Copy link
Contributor

@Atque Atque commented Jul 10, 2025

Description

We are currently limited by 100 times of unit in the ephemeris calculation menu. This is not enough e.g. if someone wishes to visualize one full orbit of Pluto, which covers 248 years, or if someone wants to see interstellar comets long-term paths.

This small fix increases the limit from 100 to 1000. One could set the limit even higher, but I don't see a reason.

Fixes # (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

Test Configuration:

  • Operating system: Irrelevant
  • Graphics Card: Irrelevant

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alex-w alex-w added this to the 25.3 milestone Jul 10, 2025
@alex-w alex-w added this to AstroCalc Jul 10, 2025
@github-project-automation github-project-automation bot moved this to Backlog in AstroCalc Jul 10, 2025
@alex-w alex-w merged commit ef16ad7 into Stellarium:master Jul 10, 2025
14 of 15 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in AstroCalc Jul 10, 2025
@Atque Atque deleted the astrocalc-wider-dates branch July 10, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants