-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2nd Iter: Ensure that hostnames without dots are excluded. #2400
Merged
Commits on Aug 5, 2023
-
2nd Iter: Ensure that hostnames without dots are excluded.
This patch fixes StevenBlack#2347. Indeed, my previous patch was missing domains with dashes (-).
Configuration menu - View commit details
-
Copy full SHA for 1f3f323 - Browse repository at this point
Copy the full SHA 1f3f323View commit details -
Indeed, even with the original regex, the following test doesn't pass. Therefore, it is necessary to add it into the tests. www.example-3045.foobar.com
Configuration menu - View commit details
-
Copy full SHA for 3b2c9dd - Browse repository at this point
Copy the full SHA 3b2c9ddView commit details
Commits on Aug 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b52e6db - Browse repository at this point
Copy the full SHA b52e6dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for df85659 - Browse repository at this point
Copy the full SHA df85659View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bf24bb - Browse repository at this point
Copy the full SHA 0bf24bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 369b483 - Browse repository at this point
Copy the full SHA 369b483View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0b6120 - Browse repository at this point
Copy the full SHA f0b6120View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6164086 - Browse repository at this point
Copy the full SHA 6164086View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4574a4a - Browse repository at this point
Copy the full SHA 4574a4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2415078 - Browse repository at this point
Copy the full SHA 2415078View commit details -
Indeed, before this patch, we were not supporting TLD which contains digits and dashes (-) when "puny-encoded".
Configuration menu - View commit details
-
Copy full SHA for 560615d - Browse repository at this point
Copy the full SHA 560615dView commit details
Commits on Sep 3, 2023
-
This "regexless" alternative just try to implement a more "generic" solution to the actual "problem". Please note that this commit will fail tests, because this commit assume that IPs are not correct rules. Please also note that the following test will also fail because the new implementation assume that is actually a parsable rule. @StevenBlack need to take a decision regarding that one rule. 0.0.0 google Also: * My editor "blacked" the file.
Configuration menu - View commit details
-
Copy full SHA for b3f93f1 - Browse repository at this point
Copy the full SHA b3f93f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15da4c8 - Browse repository at this point
Copy the full SHA 15da4c8View commit details -
Remove any potential invalid entries.
- Anything that looks like an IP will be ignored. - Anything that doesn't containt dots will be ignored.
Configuration menu - View commit details
-
Copy full SHA for 8fc7f94 - Browse repository at this point
Copy the full SHA 8fc7f94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33bd0df - Browse repository at this point
Copy the full SHA 33bd0dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for fed5590 - Browse repository at this point
Copy the full SHA fed5590View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2726591 - Browse repository at this point
Copy the full SHA 2726591View commit details
Commits on Sep 6, 2023
-
Indeed, from on: 1. We strip out IPs. 2. We strip out "potential" INVALID that: - doesn't contains dots - contains at least 2 consecutive dots - looks like an IP. From now on an acceptable subject shall: 1. have at least 1 dot. 2. NOT be an IPv4 or IPv6 3. NOT look like an IP. (Example: 258.300.10.3)
Configuration menu - View commit details
-
Copy full SHA for 65ebac6 - Browse repository at this point
Copy the full SHA 65ebac6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a3a329 - Browse repository at this point
Copy the full SHA 6a3a329View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.