Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2nd Iter: Ensure that hostnames without dots are excluded. #2400

Merged
merged 19 commits into from
Sep 6, 2023

Commits on Aug 5, 2023

  1. 2nd Iter: Ensure that hostnames without dots are excluded.

    This patch fixes StevenBlack#2347.
    
    Indeed, my previous patch was missing domains with dashes (-).
    funilrys committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    1f3f323 View commit details
    Browse the repository at this point in the history
  2. Add new test case.

    Indeed, even with the original regex, the following test doesn't
    pass. Therefore, it is necessary to add it into the tests.
    
    	www.example-3045.foobar.com
    funilrys committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    3b2c9dd View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Updates from URLHaus and KADhosts.

    StevenBlack authored and funilrys committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    b52e6db View commit details
    Browse the repository at this point in the history
  2. Update graph.

    StevenBlack authored and funilrys committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    df85659 View commit details
    Browse the repository at this point in the history
  3. Release 3.13.19

    StevenBlack authored and funilrys committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    0bf24bb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    369b483 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f0b6120 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6164086 View commit details
    Browse the repository at this point in the history
  7. Release 3.13.20

    StevenBlack authored and funilrys committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    4574a4a View commit details
    Browse the repository at this point in the history
  8. Add s2.bl-1.com to hosts file

    mulkieran authored and funilrys committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    2415078 View commit details
    Browse the repository at this point in the history
  9. Add support for exotic TLDs.

    Indeed, before this patch, we were not supporting TLD which
    contains digits and dashes (-) when "puny-encoded".
    funilrys committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    560615d View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. Add an regexless alternative.

    This "regexless" alternative just try to implement a more
    "generic" solution to the actual "problem".
    
    Please note that this commit will fail tests, because this commit
    assume that IPs are not correct rules.
    
    Please also note that the following test will also fail because
    the new implementation assume that is actually a parsable
    rule. @StevenBlack need to take a decision regarding that one rule.
    
    	0.0.0 google
    
    Also:
      * My editor "blacked" the file.
    funilrys committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    b3f93f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    15da4c8 View commit details
    Browse the repository at this point in the history
  3. Remove any potential invalid entries.

    - Anything that looks like an IP will be ignored.
    - Anything that doesn't containt dots will be ignored.
    funilrys committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    8fc7f94 View commit details
    Browse the repository at this point in the history
  4. Fix linting issue-s

    funilrys committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    33bd0df View commit details
    Browse the repository at this point in the history
  5. Fix minor logical issue.

    funilrys committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    fed5590 View commit details
    Browse the repository at this point in the history
  6. Fix logical issue.

    funilrys committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    2726591 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Fix tests and logic.

    Indeed, from on:
      1. We strip out IPs.
      2. We strip out "potential" INVALID that:
         - doesn't contains dots
         - contains at least 2 consecutive dots
         - looks like an IP.
    
    From now on an acceptable subject shall:
      1. have at least 1 dot.
      2. NOT be an IPv4 or IPv6
      3. NOT look like an IP. (Example: 258.300.10.3)
    funilrys committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    65ebac6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6a3a329 View commit details
    Browse the repository at this point in the history