-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintain Google Colab notebook internally #2420
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for this @ScriptTiger but I must decline this PR. Closing. |
No worries. We can revisit it later if it's a timing issue. |
@ScriptTiger it's not a timing issue. This PR is for a personal workflow that has no bearing here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, I'm currently maintaining the notebook on my Google Drive. This update just brings the notebook into the hosts repository so it can be maintained internally. This is simply to drop the third party (myself), and this should not bring any additional burden (of significance) to the maintenance of the repository in general.
To view the intended outcome of this update, please refer to the following commit:
https://github.com/ScriptTiger/hosts/tree/1cae8718f56f45661d0103847f7c291ef0fdd5e7
As this update includes links to the StevenBlack/hosts repository which will only exist after the update is applied, using a previous commit which includes links to the ScriptTiger/hosts repository is needed since those links already exist and can be tested now.
Features:
By opening the hosts.ipynb from the GitHub repository, GitHub recognizes the format and displays it appropriately.
By clicking the "open in colab" link from either the notebook itself or README, the notebook is directly opened by Google Colab without a third-party owner/host.
Issues related specifically to the notebook can be triaged internally by the maintainers of the hosts repository, as well as keeping full transparency of the notebook internal to the repository.