Correct 2nd Iter: Hostnames to lowercase. #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned by @StevenBlack in StevenBlack#2400, hostnames should be converted to lowercase.
|
Thank you as always Nissar @funilrys! 🌟 Merging! |
funilrys
added a commit
to funilrys/hosts
that referenced
this pull request
Sep 8, 2023
Upon checking the lastest release after merging StevenBlack#2433, I noticed that some subjects with slashes goes through. This patch fixes that by ignoring subjects which contains slashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @StevenBlack in #2400, hostnames should be converted to lowercase.